v1.2.2 (latest) is not uploaded to docker hub

[thle40]

Version of Cadence server, and client(which language)
This is very important to root cause bugs.

• Server version: v.1.2.2

Describe the bug
All versions which are pre-release or used to be pre-release are not uploaded to dockerhub

To Reproduce
Is the issue reproducible?

• yes

Steps to reproduce the behavior:
The docker images of latest version (v1.2.2) is not uploaded to docker hub

Expected behavior
The docker image of all versions are uploaded to docker hub

[sonhuynhpham]

It looks like Cadence server v1.2.2 was pre-released initially before it's officially released. The workflow that builds and publishes the server image is triggered once when the release is published:

cadence/.github/workflows/docker_publish.yml

Line 9 in a253154

types: [ published ]

However, all of its steps are conditionally to not run for prereleases:

cadence/.github/workflows/docker_publish.yml

Line 35 in a253154

if: "!github.event.release.prerelease"

After the release change its state from prerelease to release, no workflow is triggered. Hence, no image is published for v1.2.2 as the result.

I believe the solution is to add the released condition to the workflow (doc). Note that, this change will only take effect for the release drafted after this change. So, I think the Cadence team will have to manually build and publish the Docker image for this version.

[Nepoxx]

This seems to have been the case since 1.0.0 as it is the latest tagged released on dockerhub: https://hub.docker.com/r/ubercadence/server/tags?page=1&name=v1

[3vilhamster]

Thank you for reporting!
We will try to fix it on the next release.