This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Check supported server protocols during endpoint discovery #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindvs
reviewed
Mar 22, 2017
| @@ -1,302 +0,0 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Is this removed because we no longer need it? or will it be added later once we have a proper cherami-server mock?
There was a problem hiding this comment.
The existing integ tests are simply broken and they aren't currently run as part of the regular builds. And I have a work in progress that totally rewrites the integration test (along with a proper implementation of cherami-server mock). When that patch is out, this file will be removed anyways. Given that background, this patch simply deletes the file instead of attempting to fix the references within that file.
aravindvs
approved these changes
Mar 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the client does not check for the advertised protocols from server. Instead it makes an assumption about the streaming protocol and uses a hard-coded port number (for the streaming endpoint). This patch does the following:
In addition to the change above, this patch also deletes the IntegrationTest file (which was previously ignored). This code is being refactored (WIP).