Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

fix lint error in travis-ci #302

Merged
merged 4 commits into from
Oct 2, 2017
Merged

fix lint error in travis-ci #302

merged 4 commits into from
Oct 2, 2017

Conversation

mmchen
Copy link
Collaborator

@mmchen mmchen commented Sep 29, 2017

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kirg
Copy link
Contributor

kirg commented Sep 30, 2017

@mmchen, i think lint is still throwing an error:

./services/outputhost/kafkaStream.go:46:2: don't use leading k in Go names; struct field kConverter should be converter
./services/outputhost/kafkaStream.go:51:1: comment on exported type KafkaMessageConverterConfig should be of the form "KafkaMessageConverterConfig ..." (with optional leading article)

@coveralls
Copy link

coveralls commented Oct 2, 2017

Coverage Status

Changes Unknown when pulling 3baa5a8 on mingmin/fix-lint into ** on master**.

@mmchen mmchen merged commit b65ff1d into master Oct 2, 2017
@mmchen mmchen deleted the mingmin/fix-lint branch October 11, 2017 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants