This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Log metadata queries with high latency #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobeyang
approved these changes
Oct 30, 2017
thuningxu
reviewed
Oct 31, 2017
| @@ -29,6 +32,11 @@ import ( | |||
| "github.com/uber/tchannel-go/thrift" | |||
| ) | |||
|
|
|||
| const ( | |||
| pointQueryHighLatencyThreshold = 3 * time.Second | |||
| listQueryHighLatencyThreshold = 8 * time.Second | |||
There was a problem hiding this comment.
Seems too high. How about 1 second for point queries and 5 seconds for list queries?
There was a problem hiding this comment.
as discussed offline .. we'll go with these values for now; they are 'high' thresholds, but this is to prevent swamped with logs when there is an ongoing metadata issue. we will experiment to see whether we need to further refine this with one of the following:1
- rate-limit the logs, so we don't log too much
- make the timeouts dynamically configurable
- emit these with destination/cg tags, and perhaps avoid logs all together
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.