This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DLQ destinations don't need to be scaled for high throughput most of the the time and so we have different quotas for numPublisher/numConsumer extents for DLQ. However, there are two problems currently with enforcing those quotas:
(1) The publish side quotas are never enforced because of a bug
(2) The consume side allows for violation of DLQ quota when there are no regular extents to consume from. This is not OK sometimes, because DLQs can be poison pills and consuming solely from DLQs could potentially stall a consumer group. The fix will be to strictly enforce the dlq quota.
This patch fixes both (1) and (2) and updates the unit tests.