Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Make sure dlq extent quotas are honored #33

Merged
merged 5 commits into from
Jan 25, 2017
Merged

Make sure dlq extent quotas are honored #33

merged 5 commits into from
Jan 25, 2017

Conversation

venkat1109
Copy link
Contributor

DLQ destinations don't need to be scaled for high throughput most of the the time and so we have different quotas for numPublisher/numConsumer extents for DLQ. However, there are two problems currently with enforcing those quotas:

(1) The publish side quotas are never enforced because of a bug
(2) The consume side allows for violation of DLQ quota when there are no regular extents to consume from. This is not OK sometimes, because DLQs can be poison pills and consuming solely from DLQs could potentially stall a consumer group. The fix will be to strictly enforce the dlq quota.

This patch fixes both (1) and (2) and updates the unit tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 54.548% when pulling 92a655d on dlq-extent into f0355ed on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 54.539% when pulling 92a655d on dlq-extent into f0355ed on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 54.695% when pulling 9d3de8d on dlq-extent into 8bbdbd7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 54.749% when pulling f77aac2 on dlq-extent into 9bf39e1 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 54.634% when pulling 9752887 on dlq-extent into 026daaa on master.

Copy link
Contributor

@aravindvs aravindvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@venkat1109 venkat1109 merged commit 49808c2 into master Jan 25, 2017
@venkat1109 venkat1109 deleted the dlq-extent branch January 25, 2017 16:44
aravindvs pushed a commit that referenced this pull request Jan 25, 2017
* Make sure dlq extent quotas are honored

* fixed typos in unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants