This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
clean-up/rename storageMonitor -> spaceMon #330
Open
kirg
wants to merge
20
commits into
master
Choose a base branch
from
spaceMon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirg
commented
Nov 20, 2017
•
edited
Loading
edited
- Fixes multiple minor issues in the 'storageMonitor'
- potential race enabling/disabling write (create/stoppage of channel)
- new go-routine created every cycle
- ticker not stopped
- avoid logging when not in warn/alert condition
- remove two-way dependency between storehost and spaceMon
- minor annoyance: rename 'storagemonitor" to "spaceMon" to reduce file completion collision with "storehost.go" on 'stor< tab >' .. :-)
Changes Unknown when pulling 10cf0d2 on spaceMon into ** on master**. |
Changes Unknown when pulling 2954dd3 on spaceMon into ** on master**. |
Changes Unknown when pulling 6b01dc9 on spaceMon into ** on master**. |
Changes Unknown when pulling c22fe7e on spaceMon into ** on master**. |
doodle-tnw
reviewed
Nov 28, 2017
services/storehost/spaceMon.go
Outdated
// monitoring interval | ||
const spaceMonInterval = 2 * time.Minute | ||
// SpaceMonThresholdReadOnly if free-space below this, switch store to read-only | ||
SpaceMonThresholdReadOnly uint64 = 200 * GiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirg Curious as to why do the thresholds need to be so high? Is this a uber use case or does cherami need the diskspace somehow?
kiranrg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.