Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

clean-up/rename storageMonitor -> spaceMon #330

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

clean-up/rename storageMonitor -> spaceMon #330

wants to merge 20 commits into from

Conversation

kirg
Copy link
Contributor

@kirg kirg commented Nov 20, 2017

  • Fixes multiple minor issues in the 'storageMonitor'
    • potential race enabling/disabling write (create/stoppage of channel)
    • new go-routine created every cycle
    • ticker not stopped
    • avoid logging when not in warn/alert condition
    • remove two-way dependency between storehost and spaceMon
    • minor annoyance: rename 'storagemonitor" to "spaceMon" to reduce file completion collision with "storehost.go" on 'stor< tab >' .. :-)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 66.31% when pulling 87269bc on spaceMon into 27bdb2b on master.

@kirg kirg requested a review from thuningxu November 21, 2017 00:45
@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Changes Unknown when pulling 10cf0d2 on spaceMon into ** on master**.

@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Changes Unknown when pulling 2954dd3 on spaceMon into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6b01dc9 on spaceMon into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c22fe7e on spaceMon into ** on master**.

@kirg kirg changed the title rename/clean-up storageMonitor -> spaceMon clean-up/rename storageMonitor -> spaceMon Nov 21, 2017
// monitoring interval
const spaceMonInterval = 2 * time.Minute
// SpaceMonThresholdReadOnly if free-space below this, switch store to read-only
SpaceMonThresholdReadOnly uint64 = 200 * GiB

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirg Curious as to why do the thresholds need to be so high? Is this a uber use case or does cherami need the diskspace somehow?

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kiranrg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants