Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge direction in getH3UnidirectionalEdgeBoundary is inconsistent #75

Closed
nrabinowitz opened this issue Jun 7, 2018 · 1 comment · Fixed by #78
Closed

Edge direction in getH3UnidirectionalEdgeBoundary is inconsistent #75

nrabinowitz opened this issue Jun 7, 2018 · 1 comment · Fixed by #78
Labels

Comments

@nrabinowitz
Copy link
Collaborator

This may not be a big deal for most consumers, but the algorithm used for getH3UnidirectionalEdgeBoundary produces 5 edges that follow the direction of the origin's geo boundary output, and one edge that goes in the opposite direction (from the origin's vertex 5 to vertex 0).

Given that we might rewrite that algorithm to something more efficient in any case, it would be a useful requirement for the output that all edges follow consistent directionality.

@nrabinowitz nrabinowitz added the bug label Jun 7, 2018
@nrabinowitz
Copy link
Collaborator Author

Oh, rats. The same issue also results in the wrong order if the last-to-first edge is distorted and has three vertices - on a 10-vertex pentagon, the last edge has the vertexes in order [0, 8, 9], which is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant