[ADD] Added reasoning for frames + 1

visgl · Jul 22, 2021 · 513989b · 513989b
1 parent 1e1fde6
commit 513989b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/react/src/components/export-video/utils.js b/modules/react/src/components/export-video/utils.js
@@ -139,15 +139,15 @@ export function estimateFileSize(frameRate, resolution, durationMs, mediaType) {
     return `${Math.ceil((resolution[0] / 1280) * frameRate * seconds * 0.125)} MB`;
   }
   if (mediaType === 'png') {
-    // NOTE frameRate + 1 because Hubble records 1 extra frame when outputting to pictures for some reason ¯\_(ツ)_/¯
+    // Note: Adds one frame to size to account for an extra frame when exporting to pictures.
     return `${Math.floor(
       ((resolution[0] * resolution[1] * BIT_DEPTH) / MB) *
         ((frameRate + 1) * seconds) *
         COMPRESSION_RATIO
     )} MB`;
   }
   if (mediaType === 'jpeg') {
-    // NOTE frameRate + 1 because Hubble records 1 extra frame when outputting to pictures for some reason ¯\_(ツ)_/¯
+    // Note: Adds one frame to size to account for an extra frame when exporting to pictures.
     return `${Math.floor(
       ((resolution[0] * resolution[1] * BIT_DEPTH) / MB) *
         ((frameRate + 1) * seconds) *