Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] consolidate form setting props into an object #139

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Jul 9, 2021

Change list

  • Consolidated props that are used for the export settings forms.

Todo

  • disable all forms when rendering.

@coveralls
Copy link

coveralls commented Jul 9, 2021

Pull Request Test Coverage Report for Build 1013682077

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 16.701%

Totals Coverage Status
Change from base Build 1013381030: 0.0%
Covered Lines: 142
Relevant Lines: 667

💛 - Coveralls

@chrisgervang chrisgervang merged commit 94dd6c9 into master Jul 9, 2021
@chrisgervang chrisgervang deleted the chr/form-settings branch July 9, 2021 17:37
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants