Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Refinements Update #144

Merged
merged 12 commits into from Aug 16, 2021
Merged

Conversation

RaymondDashWu
Copy link
Collaborator

@RaymondDashWu RaymondDashWu commented Jul 22, 2021

Updated version of this PR. Previous PR was not merged and now touches parts of the codebase I didn't write.

Changelog

  • Preview button changed from button to icon below map preview
  • Aspect ratio added to constants.js
  • Text from "Resolution" simplified by dropping aspect ratios. Ex: "Good 16:9 (720p)" to "Good (720p)"
  • "Resolution" dropdown changed to "Quality"
  • Aspect Ratio moved to Export Settings
  • Aspect ratio option added. Only resolutions of selected aspect ratio will appear. In addition, map preview will change based on aspect ratio selected
  • Refactored many styled div to styled components and put into styled-components.js
  • Added styling changes to modal to look more consistent with Kepler's current modals
  • Fixed bug where rendering feedback overlapped with spinner.
  • Tabs renamed from Edit/Export to Animation/Settings. Filenames changed as well as references

image (2)
image

@coveralls
Copy link

coveralls commented Jul 22, 2021

Pull Request Test Coverage Report for Build 1102875575

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 19.033%

Totals Coverage Status
Change from base Build 1102115473: 0.0%
Covered Lines: 161
Relevant Lines: 680

💛 - Coveralls

@RaymondDashWu RaymondDashWu marked this pull request as ready for review August 2, 2021 18:58
@macrigiuseppe
Copy link
Collaborator

@chrisgervang Few comments:

  • if the default tab is settings, why isn't the first tab?
  • The style for the active tab seems off. Check this out

Screen Shot 2021-08-06 at 7 44 03 PM

I think the bottom border should go underneath the current active tab

@RaymondDashWu
Copy link
Collaborator Author

RaymondDashWu commented Aug 7, 2021

@chrisgervang Few comments:

  • if the default tab is settings, why isn't the first tab?
  • The style for the active tab seems off. Check this out
Screen Shot 2021-08-06 at 7 44 03 PM

I think the bottom border should go underneath the current active tab

Sorry for the confusion. That note was from the previous PR that didn't get merged in. I removed it but the reason Export isn't the default anymore was that we decided that we wanted the flow to be to allow users to select the type of animation before picking settings like resolution and aspect ratio. The currently active tab in that screenshot is Animation. I think that addresses your concern but let me know if you have more questions.

@RaymondDashWu
Copy link
Collaborator Author

RaymondDashWu commented Aug 7, 2021

Added some new bugs that I previously didn't catch. Will work on fixing them over the weekend.

@chrisgervang chrisgervang merged commit aeb374b into visgl:master Aug 16, 2021
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants