Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Feedback Refinement #64

Merged

Conversation

RaymondDashWu
Copy link
Collaborator

@RaymondDashWu RaymondDashWu commented Jan 5, 2021

Changelog

  • Rendering spinner put into separate component
  • Code cleanup (forgot to deconstruct elements of code)
  • Different messages for timings. While saving video, if it takes longer than 2 seconds it will say "Saving... Hang Tight"

@coveralls
Copy link

coveralls commented Jan 5, 2021

Pull Request Test Coverage Report for Build 463066664

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 457233530: 0.0%
Covered Lines: 2
Relevant Lines: 2

💛 - Coveralls

@RaymondDashWu RaymondDashWu marked this pull request as ready for review February 8, 2021 20:27
@chrisgervang chrisgervang self-assigned this Apr 11, 2021
@chrisgervang chrisgervang merged commit c16b6ef into visgl:master Apr 11, 2021
@chrisgervang chrisgervang deleted the rendering-feedback-refinement branch April 11, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants