This repository has been archived by the owner on May 23, 2024. It is now read-only.
Support HTTP transport with jaeger.thrift #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprithvi
reviewed
Jun 15, 2017
transport/http.go
Outdated
| } | ||
|
|
||
| // NewHTTPTransport returns a new HTTP-backend transport. url should be an http | ||
| // url o the collector to handle POST request, typically something like: |
vprithvi
reviewed
Jun 15, 2017
transport/http.go
Outdated
| // NewHTTPTransport returns a new HTTP-backend transport. url should be an http | ||
| // url o the collector to handle POST request, typically something like: | ||
| // http://hostname:14268/api/traces?format=jaeger.thrift | ||
| func NewHTTPTransport(url string, options ...HTTPOption) (*HTTPTransport, error) { |
There was a problem hiding this comment.
error seems to be always nil, do we need it?
black-adder
reviewed
Jun 15, 2017
| return 0, nil | ||
| } | ||
| err := c.send(c.spans) | ||
| c.spans = c.spans[:0] |
There was a problem hiding this comment.
my race condition senses are tingling
There was a problem hiding this comment.
the transport is meant to be used from one goroutine by the reporter
transport/http.go
Outdated
| req.SetBasicAuth(c.httpCredentials.username, c.httpCredentials.password) | ||
| } | ||
|
|
||
| _, err = c.client.Do(req) |
There was a problem hiding this comment.
shouldn't we fully read the response and close it? (even though its useless). I remember getting OOM errors for not properly closing the responses
black-adder
approved these changes
Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152