This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Define json models for SamplingStrategyResponse and use them #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use our own json models instead of depending on thrift generated classes. This will help up when we move to manual thrift generation - Use Google's gson instead of jackson-databind - Add tests for HttpSamplingManager
vprithvi
commented
Dec 5, 2016
| */ | ||
| package com.uber.jaeger.samplers.http; | ||
|
|
||
| import lombok.Value; |
There was a problem hiding this comment.
@value automatically sets the class to final, and fields to be private final
See https://projectlombok.org/features/Value.html
2 similar comments
2 similar comments
|
LGTM although I'm not a fan of "samplers/http/" as a directory name for json models. |
yurishkuro
approved these changes
Dec 5, 2016
| @@ -16,6 +16,7 @@ ext.jerseyVersion = '2.22.2' | |||
| ext.slf4jVersion = '1.7.16' | |||
| ext.jacksonVersion = '2.7.4' | |||
There was a problem hiding this comment.
Yes, it's used by crossdock
There was a problem hiding this comment.
if only by crossdock, let's move it there, so it's less confusing at the top level.
There was a problem hiding this comment.
Yeah, it seems crossdock has it's own version. It's also in use by jaeger-jaxrs2, but it seems that it's unused.
I deleted it.
1 similar comment
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help up when we move to manual thrift generation