Publish a shadow jar with thrift 0.9.2 #83
Conversation
| <dependency> | ||
| <groupId>com.uber.jaeger</groupId> | ||
| <artifactId>jaeger-thrift</artifactId> | ||
| <classifier>thrift92</classifier> |
There was a problem hiding this comment.
what does the classifier add over artifactId?
There was a problem hiding this comment.
The classifier adds in information on whether the shaded libthrift 0.9.2 is included or not.
Omitting the classifier will result in using the default artifact that does not contain the bundled libthrift. (It simply contains the generated thrift files).
In general, people never directly add jaeger-thrift because it is a transitive dependency of jaeger-core.
See http://maven.apache.org/pom.html for more information on the classifier mechanism
The classifier allows to distinguish artifacts that were built from the same POM but differ in their content. It is some optional and arbitrary string that - if present - is appended to the artifact name just after the version number.
As a motivation for this element, consider for example a project that offers an artifact targeting JRE 1.5 but at the same time also an artifact that still supports JRE 1.4. The first artifact could be equipped with the classifier jdk15 and the second one with jdk14 such that clients can choose which one to use.
There was a problem hiding this comment.
Another alternative we could investigate is not having a dependency on thrift in the first place (#84).
org.apache.thrift:libthrift:0.9.2under the classifierthrift92org.apache.thrifttoorg.shadow.apache.thrift92in the shaded jarFixes #80