This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into fix_flow_errors
- Loading branch information
Showing
2 changed files
with
78 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Want to contribute? | ||
|
||
Great! That's why this is an open source project. We use this project in our infrastructure at Uber, and we hope that it's useful to others as well. | ||
|
||
Before you get started, here are some suggestions: | ||
|
||
- Check open issues for what you want. | ||
- If there is an open issue, comment on it. Otherwise open an issue describing your bug or feature with use cases. | ||
- Before undertaking a major change, please discuss this on the issue. We'd hate to see you spend a lot of time working on something that conflicts with other goals or requirements that might not be obvious. | ||
- Write code to fix the problem, then open a pull request with tests and documentation. | ||
- The pull requests gets reviewed and then merged assuming there are no problems. | ||
- A new release version gets cut. | ||
|
||
## Developing | ||
|
||
1. `git submodule update --init` | ||
2. `npm install` | ||
3. `npm test` | ||
4. `make build-node` | ||
|
||
## Licencing | ||
|
||
- Every file must have a licence block at the top. This is enforced using `uber-licence` | ||
- If you contribute to a file in this project and are not an Uber employee, then you should | ||
add your name to the copyright section of the licence file. | ||
- Work that you contribute must be your own. | ||
|
||
## Releases | ||
|
||
Declaring formal releases requires peer review. | ||
|
||
- A reviewer of a pull request should recommend a new version number (patch, minor or major). | ||
- Once your change is merged feel free to bump the version as recommended by the reviewer. | ||
- A new version number should not be cut without peer review unless done by the project maintainer. | ||
|
||
### Cutting a new version | ||
|
||
TBD | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters