Upgrade to opentracing-javascript 0.14 #117
Conversation
|
Lets upgrade this to 0.14.2... ? |
test/opentracing_compatibility.js
Outdated
| @@ -18,7 +18,7 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| import apiCompatibilityChecks from 'opentracing/lib/test/api_compatibility.js'; | |||
| import * as apiCompatibilityChecks from 'opentracing/lib/test/api_compatibility.js'; | |||
There was a problem hiding this comment.
apiCompatibilityChecks is a default so that makes this alias incorrect unless you use apiCompatibiltiyChecks.default() below: https://github.com/opentracing/opentracing-javascript/blob/master/src/test/api_compatibility.ts#L92
|
Any update on this? It is desirable to update to 0.14 as it seems like it is latest and also got the types for use with typescript. |
yurishkuro
force-pushed
the
upgrade-ot-0.14
branch
from
0815092
to
895412f
Compare
|
@RohitRox something was broken in the tests, I do not have time to investigate. I just rebased to latest master. If you have cycles to fix the tests, feel free to grab this branch. |
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
upgrade-ot-0.14
branch
from
898ec9d
to
27f72e4
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
|
Actually, I was able to fix it. Will merge soon. |
Signed-off-by: Yuri Shkuro <ys@uber.com>
Thanks for getting this into motion. Will be glad to help with anything. |
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/opentracing/-/opentracing-0.13.0.tgz", | ||
| "integrity": "sha1-ajQUQvCdfYZrwR7QPeHjgo49aqs=" | ||
| "version": "0.14.4", | ||
| "resolved": "https://unpm.uberinternal.com/opentracing/-/opentracing-0.14.4.tgz", |
There was a problem hiding this comment.
this registry needs to be manually changed back to registry.npmjs.org
Signed-off-by: Yuri Shkuro <ys@uber.com>
Change CONTRIBUTING.md Resolves jaegertracing#117 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
There is a potentially breaking change in 0.14
opentracing/opentracing-javascript#79
Need to see how this will affect 0.10 JS code.