Allow overriding scope and tags separator #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus does not allow '-' or '.' in metric names.
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Jul 16, 2017
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
black-adder
approved these changes
Jul 17, 2017
metrics/go-kit/factory.go
Outdated
| @@ -90,6 +111,7 @@ func (f *factory) nameAndTagsList(nom string, tags map[string]string) (name stri | |||
|
|
|||
| func (f *factory) Counter(name string, tags map[string]string) metrics.Counter { | |||
| name, tagsList := f.nameAndTagsList(name, tags) | |||
| println(name) | |||
| hist.Observe(10.5) | ||
| m := findMetric(t, "namespace_subsystem_gokit_prom_hist") | ||
| require.NotNil(t, m) | ||
| assert.Equal(t, 10.5, m[0].GetHistogram().GetSampleSum()) | ||
| } | ||
|
|
||
| func TestWrapper(t *testing.T) { | ||
| f := NewFactory("", "", nil) | ||
| wf := xkit.Wrap("foo", f, xkit.ScopeSeparator(":")) |
There was a problem hiding this comment.
It looks like whoever uses prometheus has to remember to add the scope and tags separator FactoryOption to xkit because it currently defaults to '.' and if they forget everything blows up? Scary.
There was a problem hiding this comment.
it's a good point. I think we should design this differently. In practice nobody cares that prometheus factory is creates via xkit.Wrap, so I think a better design would be
metrics/
api files
go-kit/
the wrapper thing
prometheus/
something that uses go-kit wrapper but actually returns the real metrics.Factory
this way the constructor for prometheus can specify its separators
There was a problem hiding this comment.
a thing for a separate PR, however
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Jul 17, 2017
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
yurishkuro
added a commit
to jaegertracing/jaeger
that referenced
this pull request
Jul 17, 2017
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
ideepika
pushed a commit
to ideepika/jaeger
that referenced
this pull request
Oct 22, 2017
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
liontwinkle
added a commit
to liontwinkle/go-jeager
that referenced
this pull request
Aug 1, 2020
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
outdoorSpirit
added a commit
to outdoorSpirit/Go-Jag
that referenced
this pull request
May 3, 2024
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus does not allow '-' or '.' in metric names.
Cf: https://github.com/uber/jaeger/issues/273