Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement List pagination in S3 backend #22

Closed
yiranwang52 opened this issue Dec 28, 2018 · 5 comments · Fixed by #183
Closed

Implement List pagination in S3 backend #22

yiranwang52 opened this issue Dec 28, 2018 · 5 comments · Fixed by #183
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yiranwang52
Copy link
Collaborator

yiranwang52 commented Dec 28, 2018

Add pagination parameters to backend interface:
https://github.com/uber/kraken/blob/master/lib/backend/client.go
And update the logic accordingly for the S3 implementation.

@yiranwang52 yiranwang52 added the enhancement New feature or request label Dec 28, 2018
@yiranwang52 yiranwang52 added the help wanted Extra attention is needed label Mar 5, 2019
@surapuramakhil
Copy link

surapuramakhil commented Mar 24, 2019

Can I work on it?
just for clarification, a List data structure where objects are stored in S3 (simple storage service).
can you assign it? in order to avoid confits of two pull request for the same issue :)

@yiranwang52 yiranwang52 changed the title Implement List in S3 backend Implement List pagination in S3 backend Mar 25, 2019
@yiranwang52
Copy link
Collaborator Author

We made some progress on this issue, there is a list implementation, but it doesn't support pagination. You are welcome to contribute :)

Also I am having trouble assigning issues to users not already in the project. Don't worry, I doubt there will be conflicts.

@surapuramakhil
Copy link

@yiranwang52 is it in master? if not can you share the branch 😄

@surapuramakhil
Copy link

just for concept clarification. splitting a huge file into smaller parts and parts are connected through the list. am I right?

@yiranwang52
Copy link
Collaborator Author

There could be multiple objects under a path, and List return a list of names with given prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants