Skip to content

Commit

Permalink
Fixed H3Embed calls regularizer and initilizer parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
w4nderlust committed Oct 4, 2020
1 parent d220f1d commit 011598f
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions ludwig/encoders/h3_encoders.py
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,13 @@ def __init__(
embedding_size,
embeddings_on_cpu=embeddings_on_cpu,
dropout=dropout,
initializer=weights_initializer,
regularize=weights_regularizer,
weights_initializer=weights_initializer,
bias_initializer=bias_initializer,
weights_regularizer=weights_regularizer,
bias_regularizer=bias_regularizer,
activity_regularizer=activity_regularizer,
# weights_constraint=weights_constraint,
# bias_constraint=bias_constraint,
reduce_output=None
)

Expand Down Expand Up @@ -423,8 +428,6 @@ def __init__(
activity_regularizer=None,
dropout=0.0,
recurrent_dropout=0.0,
initializer=None,
regularize=True,
reduce_output='last',
**kwargs
):
Expand Down Expand Up @@ -532,8 +535,13 @@ def __init__(
embedding_size,
embeddings_on_cpu=embeddings_on_cpu,
dropout=dropout,
initializer=initializer,
regularize=regularize,
weights_initializer=weights_initializer,
bias_initializer=bias_initializer,
weights_regularizer=weights_regularizer,
bias_regularizer=bias_regularizer,
activity_regularizer=activity_regularizer,
# weights_constraint=weights_constraint,
# bias_constraint=bias_constraint,
reduce_output=None
)

Expand All @@ -556,7 +564,6 @@ def __init__(
activity_regularizer=activity_regularizer,
dropout=dropout,
recurrent_dropout=recurrent_dropout,
regularize=regularize,
reduce_output=reduce_output
)

Expand Down

0 comments on commit 011598f

Please sign in to comment.