Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loss weight is not set to a default value #702

Closed
lucaventurini opened this issue Apr 28, 2020 · 1 comment
Closed

loss weight is not set to a default value #702

lucaventurini opened this issue Apr 28, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@lucaventurini
Copy link

Describe the bug

As in title. The bug appears when we set positive_class_weight

To Reproduce

The following:

    name: MyClass
    type: binary
    loss:
        positive_class_weight: 231.58892815076564

throws an exception in:
File "/usr/local/lib/python3.6/dist-packages/ludwig/features/base_feature.py", line 317, in concat_dependencies_and_build_output loss_weight = float(self.loss['weight'])

This instead works:

    name: MyClass
    type: binary
    loss:
        positive_class_weight: 231.58892815076564
        weight: 1

Expected behavior
loss.weight should be set to a default value?

Environment (please complete the following information):

  • OS: Ubuntu
  • Python version 3.6
  • Ludwig version 0.2.2
@w4nderlust w4nderlust added the bug Something isn't working label Apr 28, 2020
@w4nderlust
Copy link
Collaborator

Should be fixed, please confirm by installing from master:

pip uninstall ludwig
pip install git+http://github.com/uber/ludwig.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants