Move waitForRender resolve into core render loop. Use for toDataURL

visgl · Mar 12, 2019 · fa40439 · fa40439
1 parent 9a91b0a
commit fa40439
Showing 1 changed file with 5 additions and 22 deletions.
diff --git a/modules/core/src/core/animation-loop.js b/modules/core/src/core/animation-loop.js
@@ -77,9 +77,6 @@ export default class AnimationLoop {
     this._resolveNextFrame = null;
     this._cpuStartTime = 0;
 
-    this._canvasDataURLPromise = null;
-    this._resolveCanvasDataURL = null;
-
     this.setProps({
       autoResizeViewport,
       autoResizeDrawingBuffer,
@@ -179,10 +176,10 @@ export default class AnimationLoop {
       this.gl.commit();
     }
 
-    if (this._canvasDataURLPromise) {
-      this._resolveCanvasDataURL(this.gl.canvas.toDataURL());
-      this._canvasDataURLPromise = null;
-      this._resolveCanvasDataURL = null;
+    if (this._resolveNextFrame) {
+      this._resolveNextFrame(this);
+      this._nextFramePromise = null;
+      this._resolveNextFrame = null;
     }
 
     this._endTimers();
@@ -214,16 +211,7 @@ export default class AnimationLoop {
   }
 
   toDataURL() {
-    if (this._canvasDataURLPromise) {
-      return this._canvasDataURLPromise;
-    }
-
-    this.setNeedsRedraw('getCanvasDataUrl');
-    this._canvasDataURLPromise = new Promise(resolve => {
-      this._resolveCanvasDataURL = resolve;
-    });
-
-    return this._canvasDataURLPromise;
+    return this.waitForRender().then(self => self.gl.canvas.toDataURL());
   }
 
   onCreateContext(...args) {
@@ -263,11 +251,6 @@ export default class AnimationLoop {
         return;
       }
       this.redraw();
-      if (this._resolveNextFrame) {
-        this._resolveNextFrame(this);
-        this._nextFramePromise = null;
-        this._resolveNextFrame = null;
-      }
       this._animationFrameId = requestAnimationFrame(renderFrame);
     };