Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example stats widget #1021

Merged
merged 5 commits into from Apr 2, 2019
Merged

Example stats widget #1021

merged 5 commits into from Apr 2, 2019

Conversation

tsherif
Copy link
Contributor

@tsherif tsherif commented Apr 1, 2019

Fix stats widget rendering in the examples. Moved all logic into the example runner, so it now renders for all examples.

@ibgreen ibgreen requested a review from jckr April 1, 2019 18:36
@@ -41,7 +41,7 @@
"@luma.gl/constants": "7.0.0-alpha.25",
"@luma.gl/webgl-state-tracker": "7.0.0-alpha.25",
"@luma.gl/webgl2-polyfill": "7.0.0-alpha.25",
"probe.gl": "3.0.0-alpha.6",
"probe.gl": "3.0.0-alpha.7",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we making more breaking changes to probe.gl? If not let's publish 3.0.0 as production release and get the dependencies updated to "^3.0.0" (with leading caret).

@@ -13,6 +13,7 @@
"serve": "gatsby serve"
},
"dependencies": {
"@probe.gl/stats-widget": "^3.0.0-alpha.9",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@coveralls
Copy link

coveralls commented Apr 1, 2019

Coverage Status

Coverage remained the same at 45.642% when pulling d72c110 on example-stats-widget into 77503b8 on master.

@tsherif tsherif merged commit 8c34b14 into master Apr 2, 2019
@Pessimistress Pessimistress deleted the example-stats-widget branch April 2, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants