Fix attribute handling for matrices #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,6 +97,7 @@ export default class ProgramConfiguration { | |||
|
|
|||
| const attributeInfo = {location, name, accessor: new Accessor(accessor)}; // Base values | |||
| this.attributeInfos.push(attributeInfo); | |||
| this.attributeInfosByLocation[location] = attributeInfo; // For quick location based lookup | |||
There was a problem hiding this comment.
Comment on the difference between attributeInfos and attributeInfosByLocation and how they differ in this edge case?
Pessimistress
approved these changes
Apr 3, 2019
ibgreen
reviewed
Apr 3, 2019
|
|
||
| // Locations may not be contiguous the case of matrix attributes | ||
| // so keep a separate location->attribute map. | ||
| this.attributeInfosByLocation = []; |
There was a problem hiding this comment.
I can't see that we need both attributeInfos and attributeInfosByLocation.
Fine with deleting either and just keeping one array that is sorted by real locations.
Nit: We may want to initialize the array to the MAX_ATTRIBUTES so we don't assign beyond array length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtle bug in attribute handling introduced by the matrix attributes.
ProgramConfigurationwas assuming that locations were consecutive starting from 0, which is not the case if there are matrix attributes. Seems to only have become an issue when trying to rebind buffers to attributes manually (when VAOs aren't available).