Don't modify input attributes #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +92,6 @@ export default class Geometry { | |||
| if (attributeName === 'indices') { | |||
| assert(!this.indices); | |||
| delete attribute.isIndexed; | |||
| delete attributes[attributeName]; | |||
There was a problem hiding this comment.
Is deleting this going to change the model behavior (creating an extra buffer)? Can we just make a copy of the attributes object?
There was a problem hiding this comment.
No, this was just modifying the input object. Buffers are created based on this.attributes.
| @@ -92,7 +92,6 @@ export default class Geometry { | |||
| if (attributeName === 'indices') { | |||
| assert(!this.indices); | |||
| delete attribute.isIndexed; | |||
There was a problem hiding this comment.
This is also mutating the input.
Pessimistress
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was interfering with reuse of deck mesh attributes.