Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gltf example promise-loading #1072

Merged
merged 1 commit into from Apr 17, 2019
Merged

Fix gltf example promise-loading #1072

merged 1 commit into from Apr 17, 2019

Conversation

georgios-uber
Copy link
Contributor

No description provided.

@georgios-uber georgios-uber self-assigned this Apr 17, 2019
ibgreen
ibgreen approved these changes Apr 17, 2019
View reviewed changes
examples/core/gltf/app.js Outdated
...options,
gl,
DracoLoader
});
};
const loadResult =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just

const data = typeof urlOrPromise === `string` ? fetch(urlOrPromise) : urlOrPromise;
parse(data, ..., {... options, gl, DracoLoader);

@coveralls
Copy link

coveralls commented Apr 17, 2019 •
edited

Coverage Status

Coverage remained the same at 44.686% when pulling c3cc365 on fix-gltf-parse into cbef3c6 on master.

@georgios-uber georgios-uber merged commit 66649cd into master Apr 17, 2019
@georgios-uber georgios-uber deleted the fix-gltf-parse branch April 17, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees

@georgios-uber georgios-uber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgios-uber @coveralls @ibgreen