Fix mipmap generation #1148
Merged
Fix mipmap generation #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1chandu
approved these changes
Jun 21, 2019
1chandu
reviewed
Jun 21, 2019
tsherif
reviewed
Jun 21, 2019
modules/webgl/src/classes/texture.js
Outdated
| @@ -195,14 +195,23 @@ export default class Texture extends Resource { | |||
| type: this.type, | |||
| dataFormat: this.dataFormat, | |||
| border: this.border, | |||
| mipmaps: false | |||
| mipmaps: this.mipmaps | |||
There was a problem hiding this comment.
This logic doesn't seem correct to me. What if you resize from a POT to NPOT size?
A better solution to me would be to just pass in mipmapping as an additional parameter (default to false).
There was a problem hiding this comment.
inside resize, it calls initialize, which will check if the texture is NPOT or not and disable mipmap for NPOT. But it is a problem if the user resizes the texture from POT to NPOT and then back to POT, the mipmap will be false.
maybe allow user to pass in mipmapping as a parameter and fallback to this.mipmaps?
added 3 commits
June 21, 2019 15:44
tsherif
approved these changes
Jun 24, 2019
|
Looks great, @xintongxia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1147 and #1146
Background
Change List