Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc fixes to Framebuffer docs #1160

Merged
merged 4 commits into from Jul 11, 2019
Merged

misc fixes to Framebuffer docs #1160

merged 4 commits into from Jul 11, 2019

Conversation

rolyatmax
Copy link

@rolyatmax rolyatmax commented Jul 10, 2019

A couple issues

  • COLOR_ATTACHMENT_0 misnamed (should be COLOR_ATTACHMENT0) (fixes Framebuffer documentation mistake #1097)
  • code sample uses framebuffer.configure({ ... }) instead of framebuffer.update({ ... })
  • the framebuffer.initialize documentation erroneously includes texture as a supported alias for COLOR_ATTACHMENT0
  • clearBuffers, configure and drawBuffers all look like Framebuffer methods in the docs, but none are implemented. Are those supposed to be there?

@rolyatmax rolyatmax self-assigned this Jul 10, 2019
@coveralls
Copy link

coveralls commented Jul 10, 2019

Coverage Status

Coverage increased (+5.2%) to 46.45% when pulling 730b3a9 on tb/fix-docs into 0dabf7f on master.

@rolyatmax rolyatmax merged commit 0460131 into master Jul 11, 2019
@rolyatmax rolyatmax deleted the tb/fix-docs branch July 11, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framebuffer documentation mistake
3 participants