Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New getDefaultShaderModules API #1168

Merged
merged 3 commits into from Jul 18, 2019
Merged

New getDefaultShaderModules API #1168

merged 3 commits into from Jul 18, 2019

Conversation

jianhuang01
Copy link
Contributor

Background

we need ability to expand default modules after the default is set, create this new API to get current default modules

Change List

  • new getDefaultShaderModules API
  • unit tests

@jianhuang01 jianhuang01 changed the title new getDefaultShaderModules API New getDefaultShaderModules API Jul 18, 2019
@coveralls
Copy link

coveralls commented Jul 18, 2019 •
edited

Coverage Status

Coverage increased (+5.2%) to 51.224% when pulling 7c4a5b3 on get_modules into 88de7d7 on master.

@jianhuang01 jianhuang01 merged commit 091b79e into master Jul 18, 2019
@jianhuang01 jianhuang01 deleted the get_modules branch July 18, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsherif tsherif tsherif approved these changes

@1chandu 1chandu Awaiting requested review from 1chandu

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jianhuang01 @coveralls @tsherif