Remove addEvents from examples #1179
Conversation
Pessimistress
force-pushed
the
x/add-events
branch
from
74641b3
to
8de8a54
Compare
| @@ -61,6 +61,7 @@ | |||
| "eslint-plugin-tree-shaking": "^1.7.3", | |||
| "gl": "^4.2.2", | |||
| "mkdirp": "^0.5.1", | |||
| "mjolnir.js": "^2.1.2", | |||
There was a problem hiding this comment.
Why would we have mjolnir.js in the main package.json? Shouldn't this be an optional dependency for examples.
There was a problem hiding this comment.
We load the examples in the browser render tests. They would crash if mjolnir is not found from the test directory.
| @@ -4493,6 +4493,11 @@ gzip-size@^5.0.0: | |||
| duplexer "^0.1.1" | |||
| pify "^4.0.1" | |||
|
|
|||
| hammerjs@^2.0.8: | |||
There was a problem hiding this comment.
Related to above, do these need to appear in the master yarn.lock?
There was a problem hiding this comment.
Trust these examples have been tested both locally and when built in the website, (and depending on its current condition, if at all possible also in the gatsby website), it is always a frustration for the website maintainer to have to fix example breakages at the release stage.
Thinking about that, could there be an issue in the website (where all examples are in one app) with mjolnir event managers not being finalized?
No description provided.