Stress test #1271
Merged
Stress test #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Oct 7, 2019
| CubeGeometry | ||
| } from '@luma.gl/core'; | ||
| import {Matrix4, radians} from 'math.gl'; | ||
| /* eslint-disable spaced-comment, max-depth */ |
There was a problem hiding this comment.
Nits:
- Usually place linter "imports". i.e.
/* global .. */above the import section. - When possible, please use
// eslint-disable-line ruleor// eslint-disable-next-line ruleto minimize the amount of code affected by the disable. May not be practical for thespaced-commentbut should be used for themax-depth.
| /* eslint-disable spaced-comment, max-depth */ | ||
| /* global document, window */ | ||
|
|
||
| /* |
There was a problem hiding this comment.
Nit: Attributions go at the very top in most files in other repos
| const matrices = new Float32Array(count * 16); | ||
| const matrixBuffer = new Buffer(gl, matrices.byteLength); | ||
|
|
||
| const vs = `\ |
There was a problem hiding this comment.
Nit: Recommend defining these as global constants above the constructor, to make the JS code here more readable.
|
|
||
| constructor(props = {}) { | ||
| super(props); | ||
| // Default value is true, so GL context is always created to verify wheter it is WebGL2 or not. |
| depthFunc: GL.LEQUAL | ||
| }); | ||
|
|
||
| const projMat = new Matrix4(); |
There was a problem hiding this comment.
Nit: type out variable names
|
|
||
| const {gl, aspect, projMat, viewMat, instancedCubes, angle} = props; | ||
|
|
||
| cpuStats.innerHTML = `CPU Time: ${this.stats |
Closed
|
I think it would be great to think though ways to manipulate this scene (or completely different scenes) to get different kinds of information. It is pretty limited in the parts of the system it hits. For this first pass, though, I just wanted to get something up and running quickly that runs heavy on both the CPU and GPU. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render 400,000 cubes in 4000 draw calls and report CPU and GPU frame time. So I can track perf improvements over the course of the refactor.