Move context creation/query functions to gltools #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
approved these changes
Nov 27, 2019
| // COMMON CONTEXT PARAMETERS | ||
| // Attempt to allocate WebGL2 context | ||
| webgl2: true, // Attempt to create a WebGL2 context (false to force webgl1) | ||
| webgl1: true, // Attempt to create a WebGL1 context (false to fail if webgl2 not available) | ||
| throwOnFailure: true, | ||
| throwOnError: false, |
There was a problem hiding this comment.
Is there documentation that needs to be updated?
There was a problem hiding this comment.
Never mentioned anywhere, never used anywhere. Just a ghost prop leftover from a prior refactor I'm guessing.
modules/webgl/src/index.js
Outdated
| withParameters, | ||
| isWebGL, | ||
| isWebGL2 | ||
| } from '@luma.gl/gltools'; |
There was a problem hiding this comment.
I think the atom modules should avoid re-exporting APIs from their dependencies. Whoever importing these from the webgl module should switch to importing from gltools, so that we are perfectly clear where things live.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createGLContext,resizeGLContext,instrumentGLContext,getContextDebugInfo,cssToDeviceRatio,cssToDevicePixels,isWebGL,isWebGL2isBrowser,isBrowserMainThread,isNode,isElectron,global,window,selfWebGL2RenderingContextandImage(are these used anywhere? luma.gl and deck.gl tests pass without them)throwOnError