Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade probe.gl #1310

Merged
merged 1 commit into from Dec 7, 2019
Merged

Upgrade probe.gl #1310

merged 1 commit into from Dec 7, 2019

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Dec 6, 2019 •
edited

Change List

  • Bump probe.gl to 3.2.0-beta
  • Remove global exports, use probe.gl/env
  • Use only one log instance (there were 3)
  • Rename log.priority (deprecated) to log.level

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.05%) to 61.587% when pulling 9eb678e on x/bump-probe into 3247ef4 on master.

tsherif
tsherif approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@tsherif tsherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Pessimistress Pessimistress merged commit 1310e16 into master Dec 7, 2019
@Pessimistress Pessimistress deleted the x/bump-probe branch December 7, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsherif tsherif tsherif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @tsherif