Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Recognize junit "before" annotations as an initializer #18

Closed
ZacSweers opened this issue Sep 16, 2017 · 1 comment
Closed

Proposal: Recognize junit "before" annotations as an initializer #18

ZacSweers opened this issue Sep 16, 2017 · 1 comment
Assignees
@lazaroclapp

Comments

@ZacSweers
Copy link
Contributor

A lot of tests use @Before or @BeforeClass annotations to initialize fields
lazaroclapp added a commit that referenced this issue Sep 16, 2017
@lazaroclapp
Add the option to provide custom initializer annotations.
1d6da77 
- One can pass the full name of initializer annotations with
  `-XepOpt:NullAway:CustomInitializerAnnotations. These will
  be acknowledged, as well as any annotation with @Initializer
  as its simple name.
- Provide sane defaults for this option and for
  `-XepOpt:NullAway:KnownInitializers=`, to match what we say
  in the wiki.
- Make org.junit.Before and org.junit.BeforeClass default initializer
  annotations.
- This fixes issues #18 and #19.
@lazaroclapp lazaroclapp mentioned this issue Sep 16, 2017
Merged
@lazaroclapp lazaroclapp self-assigned this Sep 16, 2017
lazaroclapp added a commit that referenced this issue Sep 16, 2017
@lazaroclapp
Add the option to provide custom initializer annotations. (#20)
08c50d6 
- One can pass the full name of initializer annotations with
  `-XepOpt:NullAway:CustomInitializerAnnotations. These will
  be acknowledged, as well as any annotation with @Initializer
  as its simple name.
- Provide sane defaults for this option and for
  `-XepOpt:NullAway:KnownInitializers=`, to match what we say
  in the wiki.
- Make org.junit.Before and org.junit.BeforeClass default initializer
  annotations.
- This fixes issues #18 and #19.
@lazaroclapp
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazaroclapp lazaroclapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazaroclapp @ZacSweers