Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on Posteriors Comparison Across Models #751

Closed
edwinnglabs opened this issue May 7, 2022 · 0 comments · Fixed by #755
Closed

Improvement on Posteriors Comparison Across Models #751

edwinnglabs opened this issue May 7, 2022 · 0 comments · Fixed by #755
Labels
enhancement Utils and interface enhancement / more flexibility.

Comments

@edwinnglabs
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Right now we have

params_comparison_boxplot(
        ['Default', 'Smaller Sigma'],
        [np.stack([ps['trend.unemploy'].flatten(), ps['trend.filling'].flatten(), ps['trend.job'].flatten()]).transpose(),
         np.stack([ps_smaller_prior['trend.unemploy'].flatten(), ps_smaller_prior['trend.filling'].flatten(), ps_smaller_prior['trend.job'].flatten()]).transpose()],
        ['trend.unemploy', 'trend.filling', 'trend.job'],
        box_width = .1, box_distance=0.1,
        showfliers=True
);

under https://orbit-ml.readthedocs.io/en/latest/tutorials/model_diagnostics.html

The code chunk with the np.stack, flatten, transpose looks complicated to me. Could we have something similar to the utilization of arviz (check the previous code block under same demo page).

@edwinnglabs edwinnglabs added the enhancement Utils and interface enhancement / more flexibility. label May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Utils and interface enhancement / more flexibility.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant