Skip to content

Commit

Permalink
Remove unused revisionID path
Browse files Browse the repository at this point in the history
  • Loading branch information
ascandella committed Aug 23, 2015
1 parent 90c3b70 commit 854cc3b
Showing 1 changed file with 0 additions and 11 deletions.
Expand Up @@ -131,11 +131,6 @@ public final boolean perform(final AbstractBuild<?, ?> build, final Launcher lau
diff.decorate(build, this.getPhabricatorURL(build.getParent()));
}

String revisionID = diff.getRevisionID(true);
if (CommonUtils.isBlank(revisionID)) {
return this.ignoreBuild(logger.getStream(), "Unable to load revisionID from conduit for diff ID " + diffID);
}

String phid = environment.get(PhabricatorPlugin.PHID_FIELD);

boolean runHarbormaster = !CommonUtils.isBlank(phid);
Expand Down Expand Up @@ -253,12 +248,6 @@ private CoverageProvider getUberallsCoverage(AbstractBuild build, BuildListener
}
}

private boolean ignoreBuild(PrintStream logger, String message) {
logger.println(message);
logger.println("Skipping Phabricator notification.");
return true;
}

@SuppressWarnings("UnusedDeclaration")
public boolean isCommentOnSuccess() {
return commentOnSuccess;
Expand Down

0 comments on commit 854cc3b

Please sign in to comment.