perform method signature update

[kornrunner]

Hopefully sorts java.lang.IllegalArgumentException which is being thrown as of Jenkins 2.242:

java.lang.IllegalArgumentException: Method perform not found in com.uber.jenkins.phabricator.PhabricatorNotifier (or it is private, final or static)
	at hudson.Util.getMethod(Util.java:1462)
	at hudson.Util.isOverridden(Util.java:1439)
	at jenkins.tasks.SimpleBuildStep.perform(SimpleBuildStep.java:110)
	at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:78)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:741)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
	at hudson.model.Build$BuildExecution.post2(Build.java:186)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
	at hudson.model.Run.execute(Run.java:1905)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:428)

Thanks!

[CLAassistant]

All committers have signed the CLA.

[coveralls]

Coverage remained the same at 89.949% when pulling 6759bee on kornrunner:master into e77a51b on uber:master.

[aandrius]

This issue was introduced in 2.241 jenkinsci/jenkins#4766 . Also this method is deprecated and new overloaded version is introduced

void perform(@NonNull Run<?, ?> run, @NonNull FilePath workspace, **@NonNull EnvVars env,** @NonNull Launcher launcher, @NonNull TaskListener listener)

[jglick]

Better wait for a core fix.

[artms]

Tested on our ancient Jenkins - everything seems to work

[jglick]

Was already fixed in jenkinsci/jenkins#4833. This can be closed.

[kornrunner]

Thank you.