Remove env dependency from uberallsclient #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sectioneight |
|
Looks good. Until we have a solid set of integration tests, can you verify that a job still builds with a BUILD_ID parameter and the Apply Phabricator Differential / Post Results to Phabricator options enabled? If you've verified this still works, then go ahead and ship it. Instructions here: https://wiki.jenkins-ci.org/display/JENKINS/Phabricator+Differential+Plugin just run |
jjx
pushed a commit
that referenced
this pull request
Jun 29, 2015
Remove env dependency from uberallsclient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.