Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PiranhaJava // Use Immutable structures (List/Map) for config data #41

Closed
pranavsb opened this issue May 30, 2020 · 1 comment
Closed

PiranhaJava // Use Immutable structures (List/Map) for config data #41

pranavsb opened this issue May 30, 2020 · 1 comment

Comments

@pranavsb
Copy link
Contributor

In XPFlagCleaner, mutable structures are currently used.

I'd prefer ImmutableMap and ImmutableList here and builders. But since the original code was also using mutable collections, I am absolutely fine leaving that for a follow up issue you two can assign to me 😅

Originally posted by @lazaroclapp in #39
@pranavsb pranavsb changed the title Use Immutable structures (List/Map) for config data PiranhaJava // Use Immutable structures (List/Map) for config data May 30, 2020
@mkr-plse
Copy link
Contributor

Resolved in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pranavsb @mkr-plse