Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PiranhaObjC: Use properties.json to specify configuration properties #51

Open
mkr-plse opened this issue Jun 15, 2020 · 1 comment
Open

PiranhaObjC: Use properties.json to specify configuration properties #51

mkr-plse opened this issue Jun 15, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed legacy-objc Issues/PR related to older PiranhaObjC implementation

Comments

@mkr-plse
Copy link
Contributor

Currently PiranhaObjC APIs are hardcoded. See here.
Introduce a configuration json file that contains an array of methodProperties with methodName, flagType, returnType and argumentIndex. See below.

{ "methodProperties": [ { "methodName": "isToggleEnabled", "flagType": "treated", "returnType": "boolean", "argumentIndex": 0 }, ... ], }

This properties file will be parsed and the listed APIs will be used for refactoring.
@mkr-plse mkr-plse added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers legacy-objc Issues/PR related to older PiranhaObjC implementation labels Jun 15, 2020
@mkr-plse mkr-plse mentioned this issue Jun 15, 2020
Closed
@ketkarameya
Copy link
Collaborator

If we someone onboards ObjC for Polyglot Piranha, this issue will be taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed legacy-objc Issues/PR related to older PiranhaObjC implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkr-plse @ketkarameya