Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke SetSuppressIncludeNotFoundError to ignore errors when headers files are missing #65

Closed
mkr-plse opened this issue Jun 20, 2020 · 5 comments
Labels
legacy-objc Issues/PR related to older PiranhaObjC implementation

Comments

@mkr-plse
Copy link
Contributor

mkr-plse commented Jun 20, 2020

When header files are missing in the input files to PiranhaObjC, a fatal error is thrown as follows:

tests/OptimisticNamed.m:19:10: fatal error: 'TestHeader.h' file not found
#include "TestHeader.h"
         ^~~~~~~~~~~~~~

where OptimisticNamed.m is updated to include a non-existent TestHeader.h.

The correct fix will be to call SetSuppressIncludeNotFoundError from the Piranha implementation. (see #50 (comment))

@mkr-plse mkr-plse added the legacy-objc Issues/PR related to older PiranhaObjC implementation label Jun 20, 2020
@mkr-plse
Copy link
Contributor Author

Fixed in #67.

@Samhithgb
Copy link

@mkr-plse, I am unfortunately still facing this issue after taking in the recent changes. The error message is :

/Users/samhith/Project/featuremanager/FeatureManager.h:6:9: fatal error: 'WMExchangeAccount.h' file not found
#import "WMExchangeAccount.h"

Does the current fix also consider missing header files inside another header file? Please let me know if there is any workaround I can follow to avoid this.

@mkr-plse
Copy link
Contributor Author

This should ignore all errors related to missing header files. Can you delete the existing .dylib and create a new one by run ./generate-dylib.sh and try? If not, is it possible for you to create a simple reproducer?

@mkr-plse mkr-plse reopened this Jun 24, 2020
@Samhithgb
Copy link

Hey @mkr-plse, I tried the above suggestion, and although the original error is now gone, I'm now getting the following errors :

/Users/samhith/project/featuremanager/FeatureManager.h:101:29: error: cannot find
      interface declaration for 'NSObject', superclass of 'FeatureManager'
@interface FeatureManager : NSObject
~~~~~~~~~~~~~~~~~~~~~~~~~   
/Users/samhith/project/featuremanager/FeatureManager.h:103:3: error: expected a type
+(BOOL)isAppTypeNew;
  ^
/Users/samhith/project/featuremanager/FeatureManager.h:104:3: error: expected a type
+(BOOL)loadFile;

Is there anything I can do to overcome these errors? Let me know if you need more info on this. Thanks!

@mkr-plse
Copy link
Contributor Author

I am closing this as the original problem is resolved. Will continue the discussion in the #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-objc Issues/PR related to older PiranhaObjC implementation
Projects
None yet
Development

No branches or pull requests

2 participants