Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Lint failure on protocol buffers version 2.6.1 #63

Closed
nikostrongioglou opened this issue May 6, 2018 · 1 comment
Closed

Lint failure on protocol buffers version 2.6.1 #63

nikostrongioglou opened this issue May 6, 2018 · 1 comment

Comments

@nikostrongioglou
Copy link

nikostrongioglou commented May 6, 2018

I am using protocol buffers version 2.6.1 and linting fails with the following error on debug

2018-05-06T23:59:52.701+0200	DEBUG	downloaded protobuf zip file	{"url": "https://github.com/google/protobuf/releases/download/v2.6.1/protoc-2.6.1-osx-x86_64.zip"}
zip: not a valid zip file

The URL indeed does not work and as you can see from the file prototool tries to download we are talking about an OSX system here.

Is prototool compatible with version 2 protos?

@bufdev
Copy link
Contributor

bufdev commented May 7, 2018

https://github.com/google/protobuf/releases/v2.6.1 does not have protoc.zip files for darwin or osx. For comparison, see https://github.com/google/protobuf/releases/v3.5.1. I could make this more explicit in the documentation that you need to set a release that has the proper protoc.zip files.

Protoc versions >=3 compile proto2 files just fine, I understand for reliability reasons you might not want to upgrade, but Prototool is more "looking forward", in fact the default linter checks that your files are proto3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants