Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Multiple prototool.yaml files in the same project #93

Closed
amckinney opened this issue May 25, 2018 · 3 comments
Closed

Multiple prototool.yaml files in the same project #93

amckinney opened this issue May 25, 2018 · 3 comments
Labels

Comments

@amckinney
Copy link
Contributor

We should consider the prototool.yaml hierarchy and determine whether or not we should stick to the current tree/override behavior. A single prototool.yaml at the project's root might be sufficient for now. This would also simplify some of the implementation details found in the settings package.

If there isn't an obvious need for the hierarchy, it might be worth deferring until after a 1.0 release.

@peats-bond
Copy link
Contributor

I'm in favour of one prototool.yaml for one project and slimming down internal/settings. If there is a demand for this, we can reintroduce post 1.0. Let's not make this a 1.0 blocker, however.

@bufdev
Copy link
Contributor

bufdev commented Jun 11, 2018

I think you'll want this too, but note moving to this now will lock you in later. The big thing is everywhere you see protoSets ...*file.ProtoSet and fileDescriptorSets []*FileDescriptorSet - as the code is now, it supports multiple sets of Protocol Buffer files (corresponding to multiple prototool.yaml files), and deleting that logic will make it complicated to add it back in the future (it was complicated to move to in the first place).

If you want to lock it in, that's fine too, we probably only will want a single prototool.yaml file, but just an FYI.

Note this issue is more or less a duplicate of #10.

@bufdev
Copy link
Contributor

bufdev commented Jul 11, 2018

Closing this for now as we went with one prototool.yaml file, we can re-visit in the future if we need a different setup.

@bufdev bufdev closed this as completed Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants