Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing labels in NavigationControl and GeolocateControl #959

Merged
merged 2 commits into from Dec 18, 2019
Merged

Allow customizing labels in NavigationControl and GeolocateControl #959

merged 2 commits into from Dec 18, 2019

Conversation

ahie
Copy link
Contributor

@ahie ahie commented Dec 17, 2019

No description provided.

@claassistantio
Copy link

claassistantio commented Dec 17, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

Pessimistress
Pessimistress reviewed Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also add these new props to the documentation?

@ahie
Copy link
Contributor Author

ahie commented Dec 18, 2019

Looks good. Can you also add these new props to the documentation?

Done.

Pessimistress
Pessimistress approved these changes Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pessimistress Pessimistress merged commit 737b80d into visgl:master Dec 18, 2019
Pessimistress pushed a commit that referenced this pull request Dec 19, 2019
@ahie
Allow customizing labels in NavigationControl and GeolocateContr… (#959)
13fef16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

@xintongxia xintongxia Awaiting requested review from xintongxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahie @claassistantio @Pessimistress