Fix React state update warning #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xintongxia
reviewed
Dec 30, 2019
| @@ -176,12 +176,14 @@ export default class MapController { | |||
| this.onViewportChange = onViewportChange; | |||
| this.onStateChange = onStateChange; | |||
|
|
|||
| if (!this.mapStateProps || this.mapStateProps.height !== options.height) { | |||
| const dimensionChanged = !this.mapStateProps || this.mapStateProps.height !== options.height; | |||
There was a problem hiding this comment.
Don't need check whether width changed here?
There was a problem hiding this comment.
Width does not affect normalization. A map may need to be scaled and shifted vertically to fill the height.
xintongxia
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #872
onViewportChangeduringrender(move tocomponentDidUpdate)MapController.setOptions-- we were always callingonViewportChangebecauseoldViewportwas empty.