Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up examples directory #972

Merged
merged 1 commit into from Jan 2, 2020
Merged

Clean up examples directory #972

merged 1 commit into from Jan 2, 2020

Conversation

Pessimistress
Copy link
Collaborator

  • Remove main example
  • Move examples/data to examples/.data, load large data files from CDN

@coveralls
Copy link

coveralls commented Jan 2, 2020

Coverage Status

Coverage remained the same at 39.098% when pulling 2f3b24b on x/main-example into 439e7ec on master.

@xintongxia
Copy link

  • Remove main example
  • Move examples/data to examples/.data, load large data files from CDN

what can we benefit from moving examples/data to examples/.data?

@Pessimistress Pessimistress changed the base branch from x/clusers-example to master January 2, 2020 19:51
@Pessimistress
Copy link
Collaborator Author

what can we benefit from moving examples/data to examples/.data?

I want each directory under examples/ to be a standalone project. data is just some shared JSON files.

@Pessimistress Pessimistress merged commit 1e391ce into master Jan 2, 2020
Pessimistress added a commit that referenced this pull request Jan 2, 2020
@ibgreen
Copy link
Contributor

ibgreen commented Jan 3, 2020

Nit:

I find hidden files ('.' files) to be bit frustrating, it can send users on a wild goose chase figuring out where things are.

Of course I understand and agree with the intention here, just want to encourage thinking of alternatives in the background.

@Pessimistress Pessimistress deleted the x/main-example branch September 8, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants