Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use prop-types instead of React.PropTypes #369

Closed
btford opened this issue Apr 10, 2017 · 3 comments
Closed

Migrate to use prop-types instead of React.PropTypes #369

btford opened this issue Apr 10, 2017 · 3 comments
Labels
chore

Comments

@btford
Copy link
Contributor

btford commented Apr 10, 2017

According to the react documentation:

React.PropTypes is deprecated as of React v15.5. Please use the prop-types library instead.

We should consider adopting FlowType or using the new prop-types library.

I think the FlowType approach is a bit better, but it does mean that users not using FlowType do not get the runtime checks.
@btford btford added the chore label Apr 10, 2017
@samhogg
Copy link
Contributor

samhogg commented Apr 10, 2017

@btford I just opened #368 - agreed though, Flow would be super nice

@btford
Copy link
Contributor Author

btford commented Apr 10, 2017

Oh nice! Just noticed. We should try to land your change soon, and we can progressively move to Flow after that.

@btford btford mentioned this issue Apr 10, 2017
Merged
@mcnuttandrew
Copy link
Contributor

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@btford @samhogg @mcnuttandrew