Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation unclear about Server Token in info.plist #51

Closed
hardikdevios opened this issue Jul 4, 2016 · 7 comments
Closed

Documentation unclear about Server Token in info.plist #51

hardikdevios opened this issue Jul 4, 2016 · 7 comments

Comments

@hardikdevios
Copy link

Hello as it documented in the the section

All the button needs to gather this additional information is your server token to be configured in the Info.plist as described in the SDK Configuration section. To display a time estimate, set the product ID and pickup location. To display a price estimate, you need to additionally set a dropoff location

So when I go back to SDK Configuration section i am unable to find the information for which server token key is going to be used in the app info.plist. am i missing something ?
Attaching screenshot please confirm Server token key

screen shot 2016-07-04 at 1 24 56 pm

@gask
Copy link

gask commented Jul 4, 2016

I'm having the EXACT same doubt about this.
How am I supposed to set the server token in the Info.plist?
The SDK Configuration section here doesn't say anything about it.

@faarwa
Copy link
Contributor

faarwa commented Jul 4, 2016

UberServerToken is the correct key to set in Info.plist (this seems to be missing in the SDK Configuration as you said).

@hardikdevios
Copy link
Author

Ok great cheers guys 👍

@jbrophy17
Copy link
Contributor

Sorry for the confusion, I will be sure to update the documentation for the next release

@jbrophy17 jbrophy17 changed the title Server Token in info.plist Documentation unclear about Server Token in info.plist Jul 5, 2016
@gask
Copy link

gask commented Aug 5, 2016

Just a reminder that the docs wasn't updated up until now.

@jbrophy17
Copy link
Contributor

Sorry about that, the last release was not a scheduled release and we have not yet had a chance to work through all the documentation updates.

If you want, you could open a PR with what you expected the docs to say and I would be happy to review it

@jbrophy17
Copy link
Contributor

Fixed in v0.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants