Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an opt-in to call onError anyway #24

Closed
ZacSweers opened this issue May 16, 2019 · 1 comment · Fixed by #45
Closed

Add an opt-in to call onError anyway #24

ZacSweers opened this issue May 16, 2019 · 1 comment · Fixed by #45
Labels
enhancement New feature or request
Milestone
0.3.0

Comments

@ZacSweers
Copy link
Collaborator

This way, if someone supplies their own LambdaConsumerIntrospection, they could control this behavior if they want (such as if theirs just logs an error)
@ZacSweers ZacSweers added the enhancement New feature or request label May 16, 2019
@ZacSweers ZacSweers added this to the 0.3.0 milestone May 16, 2019
@ZacSweers
Copy link
Collaborator Author

Note that this would require some reworking of internals to opt-in and allow it. Right now reportError always calls RxJavaPlugins.onError() anyway

ZacSweers added a commit that referenced this issue Aug 17, 2019
@ZacSweers
Implement TryOnError support
664537b 
This implements support for trying delegate onError calls if they opt in by implementing a new `TryOnError` interface.

This will likely need to rely on guarded delegate call machinery, and need to figure out whether that should be another config or just supersede/defer to the existing config.

Resolves #24
@ZacSweers ZacSweers mentioned this issue Aug 17, 2019
Merged
ZacSweers added a commit that referenced this issue Aug 21, 2019
@ZacSweers
Implement TryOnError support
1809336 
This implements support for trying delegate onError calls if they opt in by implementing a new `TryOnError` interface.

This will likely need to rely on guarded delegate call machinery, and need to figure out whether that should be another config or just supersede/defer to the existing config.

Resolves #24
ZacSweers added a commit that referenced this issue Sep 15, 2019
@ZacSweers
Implement ErrorReceivers support (#45)
864fba8 
* Implement TryOnError support

This implements support for trying delegate onError calls if they opt in by implementing a new `TryOnError` interface.

This will likely need to rely on guarded delegate call machinery, and need to figure out whether that should be another config or just supersede/defer to the existing config.

Resolves #24

* Split reportError and createError

* Add DeliverModifiedException marker type

* Update observers for new DeliverModifiedException API

* Rename new marker interfaces

TryOnError -> RxDogTagErrorReceiver
DeliverModifiedException -> RxDogTagModifiedExceptionReceiver

* Rename new marker interfaces

TryOnError -> RxDogTagErrorReceiver
DeliverModifiedException -> RxDogTagModifiedExceptionReceiver

* Spotless

* Spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Implement ErrorReceivers support uber/RxDogTag
1 participant
@ZacSweers