This repository has been archived by the owner on Mar 8, 2021. It is now read-only.
Fixing template generation, was not using underscore template correctly #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the underscore 1.7 back compat breaking change ? |
|
We should probably ping underscore 1.7 as well. Lgtm. |
|
Will do, updating underscore and bumping the patch version |
robskillington
added a commit
that referenced
this pull request
Sep 5, 2014
Fixing template generation, was not using underscore template correctly
|
Just a heads up, this is a known Underscore breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran into this bug just now, this fix restores uber-ngen to good working order
cc @Raynos