Address comments

aurora-opensource · Aug 16, 2019 · 17a81ef · 17a81ef
1 parent 81b5e4b
commit 17a81ef
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/modules/parser/src/parsers/parse-timeslice-data-v2.js b/modules/parser/src/parsers/parse-timeslice-data-v2.js
@@ -112,7 +112,7 @@ function parseStreamSets(streamSets, timestamp, convertPrimitive) {
       }
     }
 
-    if (streamSet.no_data_streams && noDataStreams) {
+    if (streamSet.no_data_streams) {
       noDataStreams.push(...streamSet.no_data_streams);
     }
   }

diff --git a/modules/parser/src/synchronizers/xviz-stream-buffer.js b/modules/parser/src/synchronizers/xviz-stream-buffer.js
@@ -384,10 +384,6 @@ export default class XVIZStreamBuffer {
 
     for (const streamName in timeslice.streams) {
       const value = timeslice.streams[streamName];
-      if (value === null) {
-        // Explicitly delete a stream
-        delete timesliceAtInsertPosition.streams[streamName];
-      }
       streams[streamName][index] = value;
     }
     for (const streamName in timeslice.videos) {

diff --git a/test/modules/parser/synchronizers/xviz-stream-buffer.spec.js b/test/modules/parser/synchronizers/xviz-stream-buffer.spec.js
@@ -64,7 +64,7 @@ const TEST_CASES = [
       timestamp: 1001,
       streams: {A: 1.1, B: null}
     },
-    snapshot: {A: 1.1, C: 1}
+    snapshot: {A: 1.1, B: null, C: 1}
   },
   {
     id: 'TS-8',